[PATCH] D52430: Introduce a flag to warn when ifunc symbols are used with text relocations.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Relocations.cpp:986
+      warn("using ifunc symbols when text relocations are allowed may produce "
+          "a binary that will segfault, if the object file is linked with "
+          "old version of glibc (glibc 2.28 and earlier). If this applies to "
----------------
Indentation of this and all the following lines in this parentheses are off by one. Sorry to be nitpicky, but details matter, so please take time before sending a patch for review to fix this kind of errors.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430