[PATCH] D52580: [WIP] Refactor use of signatures and store them on the AsmPrinter

[Jacob Gravelle via Phabricator via llvm-commits]

jgravelle-google added a comment.

Generally looks ok to me



================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:101
+      addSignature(std::unique_ptr<wasm::WasmSignature>(Signature));
+      // Signatures.push_back(std::unique_ptr<wasm::WasmSignature>(Signature));
+
----------------
Commented-out code (encapsulated in `addSignature`)


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:155
   const Function &F = MF->getFunction();
+  SmallVector<MVT, 4> ResultVTs;
+  SmallVector<MVT, 1> ParamVTs;
----------------
Intuitively, it feels odd to say 4 results, 1 param.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.h:28
   WebAssemblyFunctionInfo *MFI;
+  // TODO: Do the uniquing of signatures here instead of
+  std::vector<std::unique_ptr<wasm::WasmSignature>> Signatures;
----------------
Instead of...?


Repository:
  rL LLVM

https://reviews.llvm.org/D52580