[PATCH] D52614: [DebugInfo][Dexter] Divide-before-return displays wrong value in debugger

[David Stenberg via Phabricator via llvm-commits]

dstenb added a comment.

It would be good to change the title to reflect what is done in MCP (at least before submitting this).

Can the test be reduced to only contain the bb.2.sw.bb1 block?



================
Comment at: test/CodeGen/MIR/X86/pr38773.mir:46
+    %foo.0.foo.0..sroa_cast = bitcast i32* %foo to i8*, !dbg !16
+    call void @llvm.lifetime.start.p0i8(i64 4, i8* nonnull %foo.0.foo.0..sroa_cast), !dbg !16
+    call void @llvm.dbg.declare(metadata i32* %foo, metadata !12, metadata !DIExpression()), !dbg !17
----------------
Can the lifetime markers be removed?


================
Comment at: test/CodeGen/MIR/X86/pr38773.mir:50
+    %foo.0.foo.0. = load volatile i32, i32* %foo, align 4, !dbg !22, !tbaa !18
+    call void @llvm.dbg.value(metadata i32 %foo.0.foo.0., metadata !14, metadata !DIExpression()), !dbg !23
+    %foo.0.foo.0.6 = load volatile i32, i32* %foo, align 4, !dbg !24, !tbaa !18
----------------
Should unrelated debug values for other variables be removed to minimize the test?


Repository:
  rL LLVM

https://reviews.llvm.org/D52614