[PATCH] D50902: [compiler-rt][ubsan] Split Implicit Integer Truncation Sanitizer into unsigned and signed checks

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Thank you for taking a look!



================
Comment at: lib/ubsan/ubsan_handlers.h:128
 enum ImplicitConversionCheckKind : unsigned char {
-  ICCK_IntegerTruncation = 0,
+  // Kind 0 was used briefly.
+  ICCK_UnsignedIntegerTruncation = 1,
----------------
filcab wrote:
> We did release an llvm version with that kind, though.
> 
> Can you re-add it, with an "... (un)signed..." in the error message (or something better, of course), so we still support files compiled with an older (but released) compiler, please?
@filcab @vitalybuka
https://reviews.llvm.org/D50901#inline-462927

> vitalybuka
> I don't think we try support mismatched versions of clang and compiler-rt

Please make up your mind :)
Do we or don't we?

(If we do, i can just reinstate all that shiny upgrade logic, which is fully-functional)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50902