[PATCH] D52600: [LLD] [COFF] In MinGW mode, ignore relocations against a discarded section

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 27 04:47:13 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM

This is a hack and the fact that we need it is unfortunate, but looks like GNU linkers historically doesn't check that kind of bad relocations, and I don't think there's any other way to workaround. We have a similar code for ELF.

At this point, I have no objection (and actually happy to see) to make lld a drop-in replacement for the GNU linker for MinGW. Thank you for doing this!


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52600





More information about the llvm-commits mailing list