[PATCH] D52599: [XRay] Reduce overly broad 'rm' command in lit test

[Jeremy Morse via Phabricator via llvm-commits]

jmorse created this revision.
jmorse added a reviewer: dberris.
Herald added subscribers: Sanitizers, llvm-commits.

This command is supposed to clean up temporary log files from this
test, but winds up cleaning all xray log files in the cwd, which can
interfere with other test processes.

We've seen this internally as errors such as:

  rm: cannot remove 'xray-log.c-test.cc.tmp.bFiBJc': No such file or directory

Where the shell has globbed the logfile for a different test (c-test.cc here)
but a concurrent test process has deleted it by the time rm gets to running.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52599

Files:
  llvm/projects/compiler-rt/test/xray/TestCases/Posix/argv0-log-file-name.cc


Index: llvm/projects/compiler-rt/test/xray/TestCases/Posix/argv0-log-file-name.cc
===================================================================
--- llvm/projects/compiler-rt/test/xray/TestCases/Posix/argv0-log-file-name.cc
+++ llvm/projects/compiler-rt/test/xray/TestCases/Posix/argv0-log-file-name.cc
@@ -4,7 +4,7 @@
 // RUN: %clangxx_xray -std=c++11 %s -o %t
 // RUN: XRAY_OPTIONS="patch_premain=true xray_naive_log=true" %run %t > xray.log.file.name 2>&1
 // RUN: ls | FileCheck xray.log.file.name
-// RUN: rm xray-log.* xray.log.file.name
+// RUN: rm xray-log.argv0-log-file-name* xray.log.file.name
 
 // UNSUPPORTED: target-is-mips64,target-is-mips64el
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52599.167269.patch
Type: text/x-patch
Size: 675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180927/0814c5bc/attachment.bin>