[PATCH] D46662: [X86] condition branches folding for three-way conditional codes

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 22:57:50 PDT 2018


xbolva00 added a comment.

> I suggest to make this pass optional (i.e. make this pass opt-in for subtargets).

@xur are you gonna work on this? As you already measured some numbers, you can enable it for haswell, skylake, etc..



================
Comment at: test/CodeGen/X86/condbr_if.ll:35
+
+define dso_local i32 @length2_2(i32) {
+  %2 = icmp sle i32 %0, 2
----------------
We don't need "dso_local" here


https://reviews.llvm.org/D46662





More information about the llvm-commits mailing list