[PATCH] D52587: [WebAssembly] Add --[no]-export-dynamic to replace --export-default

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 18:47:21 PDT 2018


sbc100 created this revision.
Herald added subscribers: llvm-commits, dexonsmith, steven_wu, sunfish, aheejin, jgravelle-google, mehdi_amini, dschuff.

In a very recent change I introduced a --no-export-default flag
but after conferring with others it seems that this feature already
exists in gnu GNU ld and lld in the form the --export-dynamic flag
which is off by default.

This change replaced export-default with export-dynamic and also
changes the default to match the traditional linker behaviour.

Now, by default only the entry point is exported.  If other symbols
are required by the embedder when --export-dynamic or --export can
be used to export all visibility hidden symbols or individual
symbols.

This change touches a lot of tests that were relying on synmbols
being exported by default.  I imagine it will also effect many
users but do think the change is worth it match of the traditional
behaviour and flag names.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52587

Files:
  test/wasm/alias.ll
  test/wasm/archive-export.ll
  test/wasm/call-indirect.ll
  test/wasm/comdats.ll
  test/wasm/compress-relocs.ll
  test/wasm/cxx-mangling.ll
  test/wasm/local-symbols.ll
  test/wasm/locals-duplicate.test
  test/wasm/lto/archive.ll
  test/wasm/undefined-weak-call.ll
  test/wasm/visibility-hidden.ll
  test/wasm/weak-alias-overide.ll
  test/wasm/weak-alias.ll
  test/wasm/weak-symbols.ll
  test/wasm/weak-undefined.ll
  wasm/Config.h
  wasm/Driver.cpp
  wasm/Options.td
  wasm/Symbols.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52587.167230.patch
Type: text/x-patch
Size: 16005 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180927/9f39c7d7/attachment.bin>


More information about the llvm-commits mailing list