[PATCH] D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 10:16:38 PDT 2018


MaskRay added a comment.

In https://reviews.llvm.org/D52430#1246570, @emaste wrote:

> > The benefit from this that we can track and update the status of the fix and even maybe provide info about the known distributions affected/fixed on the page what can be helpful for removing this flag at some longer-term point.
>
> I prefer to have all documentation self-contained rather than relying on an external resource - we could put the information in the man page description for `--warn-ifunc-textrel`. As we already know when the glibc fix is available (upstream at least) we wouldn't have anything to keep up-to-date: we can simply describe the issue, the fixed glibc version, and note that the option will be removed in the future. Keeping track of which distros have which glibc versions seems like a lot of work.
>
> That said, this issue doesn't affect the BSDs, so you ought to proceed with whatever is most natural/useful for Linux folks.


I am sure IFUNC+DT_TEXTREL does not affect FreeBSD, but OpenBSD can be affected. Many other systems (including musl) may not support IFUNC at all.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430





More information about the llvm-commits mailing list