[PATCH] D52556: Add a test case showing the instcombine fail from D52548

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: test/Transforms/InstCombine/stop_bad_undef_propagation.ll:122-123
+  %1 = insertelement <2 x i32> %0, i32 %z, i32 1
+  %2= urem <2 x i32> %1, <i32 255, i32 255>
+  %3 = uitofp <2 x i32> %2to <2 x float>
+  %4 = shufflevector <2 x float> %3, <2 x float> undef, <3 x i32> <i32 0, i32 1, i32 undef>
----------------
Here and below: there are spacing glitches, so this doesn't compile.


================
Comment at: test/Transforms/InstCombine/stop_bad_undef_propagation.ll:126
+  %5 = shufflevector <3 x float> %x, <3 x float> %4, <3 x i32> <i32 0, i32 3, i32 4>
+  %6 = fmul reassoc nnan arcp contract <3 x float> %x, %5
+  ret <3 x float> %6
----------------
Here and in all tests: do we need fast-math-flags?


================
Comment at: test/Transforms/InstCombine/stop_bad_undef_propagation.ll:130
+
+define <3 x float> @urem1(<3 x float> %x, i32 %y, i32 %z) {
+; CHECK-LABEL: @urem1(
----------------
It's not clear what different problems each of the 3 tests per opcode are demonstrating. Please add a comment at the top of the file or give the tests a meaningful name that describes what is changing between the tests.


Repository:
  rL LLVM

https://reviews.llvm.org/D52556