[PATCH] D52486: [AArch64][v8.5A] Add MTE as an optional AArch64 extension

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 26 03:33:53 PDT 2018


SjoerdMeijer added inline comments.


================
Comment at: include/llvm/Support/AArch64TargetParser.def:74
 AARCH64_ARCH_EXT_NAME("rng",      AArch64::AEK_RAND,     "+rand",  "-rand")
+AARCH64_ARCH_EXT_NAME("memtag",   AArch64::AEK_MTE,      "+mte",   "-mte")
 #undef AARCH64_ARCH_EXT_NAME
----------------
olista01 wrote:
> eugenis wrote:
> > Just wondering, is there a reason this is called "memtag" and not "mte"?
> I think we picked "memtag" over "mte" as it is more likely to be meaningful to users who don't remember all of the acronyms.
For exactly that reason, I was thinking about commenting on "rng" on the other patch, because I initially found that a bit cryptic. Why not just "rand", which I think is a lot more meaninfull than rng. But anyway, this is probably bikeshedding, and rng has probably been synchronised with the GCC community...


Repository:
  rL LLVM

https://reviews.llvm.org/D52486





More information about the llvm-commits mailing list