[PATCH] D52279: [sanitizer] Make __sanitizer::CheckFailed not public

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Sorry to say, but this broke asan on windows for me (on i386 only though).

For me, __asan::register_dso_globals() in asan_globals_win.cc.obj in clang_rt.asan_dynamic_runtime_thunk-i386 refers to this symbol, which previously used to be exported from clang_rt.asan_dynamic-i386. So even though it in principle shouldn't be part of the public interface, the way the static/dynamic parts of asan for windows is structured, this needs to be exported there.

It doesn't seem to trigger any issue on x86_64 though; I think the compiler can assume that the CheckFailed call in asan_globals_win.cc.obj can't be triggered there and doesn't emit any call.

Should we revert this again, or readd the attribute for windows builds only?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52279