[PATCH] D52500: [llvm-exegesis] Output the unscaled value as well as the scaled one.

[Guillaume Chatelet via Phabricator via llvm-commits]

gchatelet added inline comments.


================
Comment at: tools/llvm-exegesis/lib/BenchmarkResult.h:43
+  // This is the scaled value, i.e. measured quantity per instruction.
+  double ScaledValue;
+  // This is the raw value, i.e. measured quantity for the whole snippet.
----------------
`PerInstructionValue`


================
Comment at: tools/llvm-exegesis/lib/BenchmarkResult.h:45
+  // This is the raw value, i.e. measured quantity for the whole snippet.
+  double RawValue;
   std::string DebugString;
----------------
`SnippetValue`


================
Comment at: tools/llvm-exegesis/lib/BenchmarkRunner.cpp:93
+    // Scale the measurements by instruction.
+    BM.ScaledValue /= InstrBenchmark.NumRepetitions;
+    // Scale the measurements by snippet.
----------------
Can you assert that `InstrBenchmark.NumRepetitions!=0`?


Repository:
  rL LLVM

https://reviews.llvm.org/D52500