[PATCH] D52408: [ELF] - Do not fail on R_*_NONE relocations when parsing the debug info.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 25 08:58:49 PDT 2018
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: ELF/DWARF.cpp:77-79
+ // Different tools may eliminate relocations and replace them with R_*_NONE
+ // relocations. That means "nothing to relocate". We should just ignore
+ // this case, as it is not an error.
----------------
I don't think you need a comment, as a none relocation is a no-op in any context.
https://reviews.llvm.org/D52408
More information about the llvm-commits
mailing list