[PATCH] D52525: [AArch64] Fix range check of R_AARCH64_TLSLE_ADD_TPREL_HI12

[Ryan Prichard via Phabricator via llvm-commits]

rprichard added a comment.

For context, I didn't notice this bug because I needed more than 2^23 bytes of TLS LE memory, but because I was experimenting with using a variant 2 TLS layout with Android/AArch64. The standard layout (variant 1 with a 2-word TCB) is a problem because Bionic has allocated some memory that overlaps with the first TLS segment, accessible using TLS LE. In particular, the stack cookie is a problem (see getStackCookieLocation in https://reviews.llvm.org/D18632), because third-party binaries may be assuming a variant-1 incompatible TLS layout.

This range check bug isn't related to Android, though.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52525