[PATCH] D52450: [Intrinsic] Add llvm.minnan and llvm.maxnan instrinsic functions

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 25 12:28:27 PDT 2018


aheejin added a comment.

Are these all places we need to handle these new intrinsics? Searching by `minnum` or `maxnum` in the llvm directory yields other occurrences in files like `lib/Analysis/ValueTracking.cpp`, `lib/Analysis/VectorUtils.cpp`, and `lib/Analysis/InstructionSimplify.cpp`. (There are more). For test cases as well.



================
Comment at: include/llvm/ADT/APFloat.h:1262
+  return (A.compare(B) == APFloat::cmpLessThan) ? B : A;
+}
+
----------------
Maybe add 1-2 line comments to these two, like other functions?


Repository:
  rL LLVM

https://reviews.llvm.org/D52450





More information about the llvm-commits mailing list