[PATCH] D50913: [FPEnv] Don't need copysign/fabs/fneg constrained intrinsics

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 25 10:13:50 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D50913#1245120, @cameron.mcinally wrote:

> There hasn't been any strong objects, but I haven't seen many strong accepts either besides the few main stakeholders. I'm under the assumption that silence is a passive reject in situations like this.
>
> Should I keep pushing for it? It felt like I was beating a dead horse...


I don't know if I qualify as a main stakeholder, but since I've been futzing around with fast-math-flags and IR canonicalization for a few years now...
I thought we had consensus that adding fneg to IR was desirable, so I didn't bother to repeat any of the people that did reply to the dev thread.

I do have 1 concern though - let me reply to the dev thread with that since that's the wider audience in theory.


Repository:
  rL LLVM

https://reviews.llvm.org/D50913





More information about the llvm-commits mailing list