[PATCH] D52408: [ELF] - Do not fail on R_*_NONE relocations when parsing the debug info.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/DWARF.cpp:80
+    RelType Type = Rel.getType(Config->IsMips64EL);
+    if (Target->getRelExpr(Type, File->getRelocTargetSym(Rel), Loc) != R_NONE)
+      error(toString(File) + ": relocation " + lld::toString(Type) + " at 0x" +
----------------
Looks like calling `getRelExpr` is overkill as you don't really need a symbol and a relocation target location. You probably should define a more lightweight predicate or just `Target->NoneRelType`.


https://reviews.llvm.org/D52408