[PATCH] D52463: [ARM] Fix for PR39060

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 25 06:29:38 PDT 2018


samparker created this revision.
samparker added reviewers: hans, SjoerdMeijer.
Herald added subscribers: chrib, kristof.beyls, srhines.
Herald added a reviewer: javed.absar.

When calculating whether a value can safely overflow for use by an icmp, we weren't checking that the value couldn't wrap around. To do this we need the icmp to be using a constant, as well as the incoming add or sub.

bugzilla report: https://bugs.llvm.org/show_bug.cgi?id=39060


https://reviews.llvm.org/D52463

Files:
  lib/Target/ARM/ARMCodeGenPrepare.cpp
  test/CodeGen/ARM/arm-cgp-overflow.ll
  test/CodeGen/ARM/arm-cgp-signed-icmps.ll
  test/CodeGen/ARM/pr39060.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52463.166868.patch
Type: text/x-patch
Size: 11572 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180925/ffc1c9ef/attachment.bin>


More information about the llvm-commits mailing list