[PATCH] D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Please separate your commit message into multiple paragraphs. I'd start a new line before "So, with this change".

Also I'd mention that "This patch adds a new flag, --warn-ifunc-textrel, to work around a nasty glibc bug." as the first sentence of the commit message.



================
Comment at: ELF/Relocations.cpp:986
+    if (!Config->ZText && Config->WarnIfuncTextrel) {
+      warn("using IFUNC symbols when text relocations are allowed may produce "
+          "a binary that will segfault, if the object file is linked with "
----------------
Please add the latest version of glibc and today's date along with a link to the bug management system's entry for the glibc crash issue as a comment, so that we can easily check whether a bug is fixed or not in the future. This flag is temporary; this is a workaround for the nasty glibc bug. We want to remove the flag within perhaps 5 years.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430