[PATCH] D52430: Introduce a flag to warn when IFUNC symbols are used with text relocations.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 24 20:35:54 PDT 2018


MaskRay added inline comments.


================
Comment at: test/ELF/textrel.s:14
+# RUN: not ld.lld --warn-ifunc-textrel --fatal-warnings -z notext
+#   %t.o -o /dev/null 2>&1 | FileCheck %s --check-prefix=error
+# CHECK: error: Using IFUNC symbols when text relocations are allowed may
----------------
`--check-prefix=error` inspects `CHECK-error:` (missing in this file). I think the next line should be changed. It is also conventional to use an uppercase name.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52430





More information about the llvm-commits mailing list