[PATCH] D52324: [ValueTracking] Allow select patterns to work on vectors in more places

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Analysis/ValueTracking.cpp:4427
+  }
+
   return false;
----------------
It looks like these are now repeating functionality of [[ https://github.com/llvm-mirror/llvm/blob/78f1b6d15e1a256882da9c59855ca29ce13156a3/lib/IR/Constants.cpp#L244-L255 | `Constant::isNaN` ]] and [[ https://github.com/llvm-mirror/llvm/blob/78f1b6d15e1a256882da9c59855ca29ce13156a3/lib/IR/Constants.cpp#L63-L83 |  `Constant::isZeroValue` ]]. Can we use them instead?


================
Comment at: unittests/Analysis/ValueTrackingTest.cpp:115
+  expectPattern({SPF_UNKNOWN, SPNB_NA, false});
+}
+
----------------
Could you add some comments for the tests about what each test is testing?


Repository:
  rL LLVM

https://reviews.llvm.org/D52324