[llvm] r342674 - Fix -Wtrigraphs.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 24 18:00:06 PDT 2018


What's the purpose of the three question marks here? Are they there to
indicate confusion? In which case maybe a more specific description would
be suitable (& avoid the trigraph issue)?

On Thu, Sep 20, 2018 at 11:27 AM Rui Ueyama via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: ruiu
> Date: Thu Sep 20 11:26:38 2018
> New Revision: 342674
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342674&view=rev
> Log:
> Fix -Wtrigraphs.
>
> Modified:
>     llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp
>
> Modified: llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp?rev=342674&r1=342673&r2=342674&view=diff
>
> ==============================================================================
> --- llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp (original)
> +++ llvm/trunk/tools/llvm-pdbutil/MinimalTypeDumper.cpp Thu Sep 20
> 11:26:38 2018
> @@ -41,7 +41,7 @@ static std::string formatClassOptions(ui
>          Stream->findFullDeclForForwardRef(CurrentTypeIndex);
>      if (!ETI) {
>        consumeError(ETI.takeError());
> -      PUSH_FLAG(ClassOptions, ForwardReference, Options, "forward ref
> (???)");
> +      PUSH_FLAG(ClassOptions, ForwardReference, Options, "forward ref
> (??\?)");
>      } else {
>        const char *Direction = (*ETI == CurrentTypeIndex)
>                                    ? "="
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180924/2317ae13/attachment.html>


More information about the llvm-commits mailing list