[PATCH] D52156: [LLD] [COFF] Alternative ARM range thunk algorithm

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 24 13:18:26 PDT 2018


mstorsjo added a comment.

In https://reviews.llvm.org/D52156#1243810, @ruiu wrote:

> I believe you can iterate over all input files to visit all symbols including local ones.


Ah, yes. I have this working now - the speedup isn't significant, but it turned out I looked at the wrong numbers for the sizes. While Defined itself is significantly smaller than SymbolUnion, Defined itself has got lots of subclasses, and adding this extra field does grow SymbolUnion from 56 to 64 bytes. Do you still think it's worth it?


https://reviews.llvm.org/D52156





More information about the llvm-commits mailing list