[PATCH] D51664: [IR] Lazily number instructions for local dominance queries

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 24 10:24:19 PDT 2018


kuhar added inline comments.


================
Comment at: llvm/include/llvm/IR/BasicBlock.h:487
 
+#ifdef NDEBUG
+/// In release builds, this is a no-op. For !NDEBUG builds, the checks are
----------------
rnk wrote:
> kuhar wrote:
> > Does it make sense to disable this when EXPENSIVE_CHECKS are set?
> I would assume EXPENSIVE_CHECKS implies !NDEBUG, and these checks are on when assertions enabled.
I think you can use expensive checks independently of build type


https://reviews.llvm.org/D51664





More information about the llvm-commits mailing list