[PATCH] D52249: [hwasan] Record and display stack history in stack-based reports.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc accepted this revision.
kcc added a comment.

LGTM with nits.



================
Comment at: compiler-rt/lib/hwasan/hwasan_report.cc:39
 
+class SavedStackAllocations {
+ public:
----------------
plz comment why we need this


================
Comment at: compiler-rt/lib/hwasan/hwasan_thread_list.h:22
+// sized region below and adjacent to the shadow region.
+// * Each ring buffer has a size of (2**N)*4096 where N is in [0, 8), and is
+// aligned to twice its size. The value of N can be different for each buffer.
----------------
can N actually be 0? 
If so, please add a run-time test, although I would rather say N is [1,8)


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:718
+    // must be aligned by twice that much. Therefore wrap around of the ring
+    // buffer is simply Addr &= ~((ThreadLong >> 56) << 10).
+    // The use of AShr instead of LShr is due to
----------------
10, not 12? 


https://reviews.llvm.org/D52249