[PATCH] D52327: [Loop Vectorizer] Abandon vectorization when no integer IV found

Warren Ristow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 15:39:27 PDT 2018


wristow added a comment.

In https://reviews.llvm.org/D52327#1242611, @hsaito wrote:

> In https://reviews.llvm.org/D52327#1242439, @wristow wrote:
>
> > Regarding the LIT test from https://reviews.llvm.org/D47216, isn't that essentially the same as the LIT test I have here?
>
>
> I say yes and no. One induction versus two inductions. Given that there were none before, it's nice to have more than one, especially so if another one is handily available. I don't insist, though.


Makes sense.  I'll add that second test.

In https://reviews.llvm.org/D52327#1242612, @hsaito wrote:

> LGTM. We can continue discussing about not bailing out for the subset of cases, but we don't have to let the compiler crash while we do that.


Thanks!  I'll commit after adding that test.


https://reviews.llvm.org/D52327





More information about the llvm-commits mailing list