[PATCH] D38513: [LLD] [COFF] Add support for GNU binutils import libraries

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM. Beautiful!



================
Comment at: COFF/Writer.cpp:428
+}
+// Add generated idata chunks, for imported symbols and DLLs, and a
+// terminator in .idata$2.
----------------
Add a blank line.


================
Comment at: COFF/Writer.cpp:442
+  };
+  // The loader assumes a specific order of data.
+  // Add each type in the correct order.
----------------
Add a blank line before a multiline comment.


================
Comment at: COFF/Writer.cpp:450-451
+}
+
+void Writer::locateImportTables(
+    std::map<std::pair<StringRef, uint32_t>, std::vector<Chunk *>> &Map) {
----------------
Please write a function comment.


https://reviews.llvm.org/D38513