[PATCH] D52353: Fix asserts when linking wrong address space declarations

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 11:55:31 PDT 2018


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM

The only edge case I'm concerned about is that If you link together two modules, and neither has a definition, we just arbitrarily choose an address-space.  But the AsmPrinter should be able to handle that, I guess.


https://reviews.llvm.org/D52353





More information about the llvm-commits mailing list