[PATCH] D38513: [LLD] [COFF] Add support for GNU binutils import libraries
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 21 09:17:01 PDT 2018
ruiu added inline comments.
================
Comment at: COFF/Writer.cpp:383
+ for (auto &Pair : Map) {
+ const StringRef &SectionName = Pair.first.first;
+ uint32_t OutChars = Pair.first.second;
----------------
StringRef is a small object and we usually copy them instead of creating references or pointers to them.
================
Comment at: COFF/Writer.cpp:399
+ for (auto &Pair : Map) {
+ const StringRef &SectionName = Pair.first.first;
+ if (!SectionName.startswith(".idata"))
----------------
Ditto
================
Comment at: COFF/Writer.cpp:428
// Create output section objects and add them to OutputSections.
void Writer::createSections() {
// First, create the builtin sections.
----------------
This function got a bit too long. Do you think there's a way to refactor?
https://reviews.llvm.org/D38513
More information about the llvm-commits
mailing list