[PATCH] D52085: [ARM][ARMLoadStoreOptimizer]

[Matthias Braun via Phabricator via llvm-commits]

MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

The new .mir test is nicely concise now. Maybe we can even do without the .ll test now?

LGTM with nitpicks addressed and when Eli agrees.



================
Comment at: test/CodeGen/ARM/load_store_opt_reg_limit.mir:2-10
+--- |
+  target datalayout = "e-m:e-p:32:32-i64:64-v128:64:128-a:0:32-n32-S64"
+  target triple = "thumbv7--linux-android"
+
+  define void @_Z2brR1lI1ME() {
+    ret void
+  }
----------------
You should be able to drop the whole IR block too I think.


================
Comment at: test/CodeGen/ARM/load_store_opt_reg_limit.mir:12
+---
+#CHECK: _Z2brR1lI1ME
+name:            _Z2brR1lI1ME
----------------
Better style: `# CHECK-LABEL: name: _Z2brR1lI1ME` (may also consider choosing a simpler function name)


https://reviews.llvm.org/D52085