[PATCH] D52317: Add support for dynamic libraries on Hexagon

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/Arch/Hexagon.cpp:44
+  PltEntrySize = 16;
+  PltHeaderSize = 0; // MUSL isn't lazy so there is no reason to make a header.
+
----------------
sidneym wrote:
> sidneym wrote:
> > ruiu wrote:
> > > Is this an ABI specification that it doesn't support lazy PLT resolution?
> > The ABI does support Lazy binding,
> I can add the header, I didn't because it wasn't getting used.
OK, can you expand the comment a bit? It is not clear to me that why you mentioned musl here. I guess musl is a commonly used libc for Hexagon?


================
Comment at: ELF/Arch/Hexagon.cpp:226
+void Hexagon::writePlt(uint8_t *Buf, uint64_t GotPltEntryAddr, uint64_t PltEntryAddr,
+              int32_t Index, unsigned RelOff) const {
+  const uint8_t Inst[] = {
----------------
Format.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D52317