[PATCH] D52361: [XRay][compiler-rt] Update use of internal_mmap

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 08:35:03 PDT 2018


dberris added inline comments.


================
Comment at: compiler-rt/lib/xray/xray_allocator.h:125
                         MAP_PRIVATE | MAP_ANONYMOUS, -1, 0));
       if (BackingStore == MAP_FAILED) {
         BackingStore = nullptr;
----------------
cryptoad wrote:
> There appears to be another use of `internal_mmap` here with a `MAP_FAILED` check.
Good catch, thanks!


https://reviews.llvm.org/D52361





More information about the llvm-commits mailing list