[compiler-rt] r342698 - [fuzzer] Replace FuzzerExtFunctionsDlsymWin.cpp with FuzzerExtFunctionsWeakAlias.cpp

[Jonathan Metzman via llvm-commits]

On Fri, Sep 21, 2018 at 3:55 AM, Jeremy Morse <jeremy.morse.llvm at gmail.com>
wrote:

> Hi Jonathan,
>
> For this test modification:
>
> On Fri, Sep 21, 2018 at 12:24 AM, Jonathan Metzman via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> --- compiler-rt/trunk/test/fuzzer/fuzzer-flags.test (original)
>> +++ compiler-rt/trunk/test/fuzzer/fuzzer-flags.test Thu Sep 20 16:24:48
>> 2018
>> @@ -1,6 +1,3 @@
>> -# FIXME: Disabled on Windows since LLVMFuzzerInitialize does not yet
>> work.
>> -UNSUPPORTED: windows
>> -RUN: %cpp_compiler %S/FlagsTest.cpp -o %t-FlagsTest
>>  RUN: %run %t-FlagsTest -runs=10 -foo_bar=1 2>&1 | FileCheck %s
>> --check-prefix=FOO_BAR
>>  FOO_BAR: WARNING: unrecognized flag '-foo_bar=1'; use -help=1 to list
>> all flags
>>  FOO_BAR: BINGO
>>
>
> I don't believe deleting the run-line generating the test binary was
> intentional? -- it breaks this buildbot [0] at the least. FYI I've re-added
> that line in r342720.
>

Jeremy: you're correct that this deletion was unintentional. Thank you for
fixing this.


>
> [0] http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/13271
>
> --
> Thanks,
> Jeremy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180921/9d808b97/attachment.html>