[PATCH] D52358: [X86][Sched] Add zero idiom sched data to the SNB model.
Andrea Di Biagio via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 21 07:02:06 PDT 2018
andreadb accepted this revision.
andreadb added a comment.
This revision is now accepted and ready to land.
Nice!
On SNB, renamer-based zeroing does not work for:
16 and 8-bit GPRs[1].
MMX [2].
ANDN variants [3]
Could you add that info as a small comment in test `llvm-mca/X86/SandyBridge/zero-idioms.s` ? So that people don't get confused when they find that some instructions from that test have a non-zero latency.
>From a tablegen point of view, the patch looks good to me.
I don't have a sandybridge, so I cannot test if those numbers are valid. However, I trust you that you have verified those with exegesis.
P.s.: are you planning to look at this for other models?
Thanks a lot Clement!
Repository:
rL LLVM
https://reviews.llvm.org/D52358
More information about the llvm-commits
mailing list