[PATCH] D51276: [New PM][PassTiming] implement -time-passes for the new pass manager

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev marked 4 inline comments as done.
fedor.sergeev added inline comments.


================
Comment at: include/llvm/IR/PassTimingInfo.h:104
+
+  /// Prints out timing information and then resets the timers.
+  void print();
----------------
philip.pfaffe wrote:
> The implementation doesn't reset.
It actually does. This is a weird part of underneath TimeGroup::print() functionality.


================
Comment at: include/llvm/IR/PassTimingInfo.h:127
+  /// Destructor handles the print action if it has not been handled before.
+  ~TimePassesHandler();
+
----------------
philip.pfaffe wrote:
> Why is this explicit when it doesn't do anything?
Just to add a comment! :)


================
Comment at: include/llvm/IR/PassTimingInfo.h:154
+
+  std::unique_ptr<PassTimingInfo<StringRef>> TimingInfo;
+};
----------------
philip.pfaffe wrote:
> Why doesn't this contain the object directly?
To avoid creating TimingInfo (its TimeGroup member in particular) if -time-passes is not enabled.


Repository:
  rL LLVM

https://reviews.llvm.org/D51276