[PATCH] D52349: [XRay] Clean up XRay build configuration

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 03:35:03 PDT 2018


dberris created this revision.
dberris added reviewers: echristo, beanz.
Herald added subscribers: hiraditya, mgorny.

This change spans both LLVM and compiler-rt, where we do the following:

- Add XRay to the LLVMBuild system, to allow for distributing the XRay

trace loading library along with the LLVM distributions.

- Use `llvm-config` better in the compiler-rt XRay implementation, to

depend on the potentially already-distributed LLVM XRay library.

While this is tested with the standalone compiler-rt build, it does
require that the LLVMXRay library (and LLVMSupport as well) are
available during the build. In case the static libraries are available,
the unit tests will build and work fine. We're still having issues with
attempting to use a shared library version of the LLVMXRay library since
the shared library might not be accessible from the standard shared
library lookup paths.

The larger change here is the inclusion of the LLVMXRay library in the
distribution, which allows for building tools around the XRay traces and
profiles that the XRay runtime already generates.


https://reviews.llvm.org/D52349

Files:
  compiler-rt/cmake/Modules/CompilerRTUtils.cmake
  compiler-rt/lib/xray/tests/CMakeLists.txt
  compiler-rt/lib/xray/tests/unit/CMakeLists.txt
  llvm/lib/LLVMBuild.txt
  llvm/lib/XRay/LLVMBuild.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52349.166435.patch
Type: text/x-patch
Size: 5363 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180921/8e099dce/attachment.bin>


More information about the llvm-commits mailing list