[PATCH] D52243: [ConstHoist]Do NOT rebase single-dependent of base constant
Dave Green via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Sep 21 02:06:49 PDT 2018
dmgreen added inline comments.
================
Comment at: test/CodeGen/Thumb/consthoist-single-dependent.ll:1
+; RUN: llc %s -o - | FileCheck %s
+
----------------
dmgreen wrote:
> Would these tests make more sense as opt tests? That way they can just test this specific pass, not the entire backend.
Perhaps as-well-as, not instead-of? If you still want to test this behaviour too.
Repository:
rL LLVM
https://reviews.llvm.org/D52243
More information about the llvm-commits
mailing list