[PATCH] D52343: [llvm-exegesis] Fix PR39021.

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 01:28:31 PDT 2018


courbet created this revision.
courbet added reviewers: tycho, gchatelet, john.brawn.
Herald added subscribers: tschuett, mgorny.

The `set` statements was incorrectly reading the value of the local variable and
setting the value of the parent variable.


Repository:
  rL LLVM

https://reviews.llvm.org/D52343

Files:
  tools/llvm-exegesis/lib/CMakeLists.txt


Index: tools/llvm-exegesis/lib/CMakeLists.txt
===================================================================
--- tools/llvm-exegesis/lib/CMakeLists.txt
+++ tools/llvm-exegesis/lib/CMakeLists.txt
@@ -1,12 +1,16 @@
+set(TARGETS_TO_APPEND "")
+
 if (LLVM_TARGETS_TO_BUILD MATCHES "X86")
   add_subdirectory(X86)
-  set(LLVM_EXEGESIS_TARGETS "${LLVM_EXEGESIS_TARGETS} X86" PARENT_SCOPE)
+  set(TARGETS_TO_APPEND "${TARGETS_TO_APPEND} X86")
 endif()
 if (LLVM_TARGETS_TO_BUILD MATCHES "AArch64")
   add_subdirectory(AArch64)
-  set(LLVM_EXEGESIS_TARGETS "${LLVM_EXEGESIS_TARGETS} AArch64" PARENT_SCOPE)
+  set(TARGETS_TO_APPEND "${TARGETS_TO_APPEND} AArch64")
 endif()
 
+set(LLVM_EXEGESIS_TARGETS "${LLVM_EXEGESIS_TARGETS} ${TARGETS_TO_APPEND}" PARENT_SCOPE)
+
 add_library(LLVMExegesis
   STATIC
   Analysis.cpp


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52343.166411.patch
Type: text/x-patch
Size: 814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180921/32813b26/attachment.bin>


More information about the llvm-commits mailing list