[PATCH] D52257: [Thumb1] Any imm of i8 type on Thumb1 should have cost of 1

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 21 01:08:22 PDT 2018


SjoerdMeijer added a comment.

Ah, but looking a bit closer now, I am not sure this is the right thing to do. This changes makes any 8 bit value cheap, including negative numbers. And I am not sure if this is the right thing to do, since the Thumb1 immediates are positive numbers. It looks this a workaround for store-merging interacting badly with constant hoisting.


Repository:
  rL LLVM

https://reviews.llvm.org/D52257





More information about the llvm-commits mailing list