[PATCH] D52341: [mctoll] Initial changes for MC to LL raiser that takes a binary and raises it back to llvm bitcode

[Kristof Beyls via Phabricator via llvm-commits]

kristof.beyls added a comment.

Hi Aaron,

Thanks for sharing - this looks like an interesting tool.
Having scrolled real quickly through the code, I'm assuming that as is, this is the version of the tool as you created more or less out-of-tree?
Or in other words, a bit of polish probably is needed to get it integrated better - e.g.

- is the LICENSE.TXT file necessary?
- Some of the testing seems to require quite a lot of things to be enabled in the build - so maybe that needs refinement?
- Do we really want to build and run (pristine?) dhrystone as part of testing?

However, I'm assuming those are just details at the moment.
I think it may be good to kick of a thread on llvm-dev about introducing this tool. I'm assuming that'll increase visibility, reaching more people who have built similar tools in the past.
Not being an expert in this area, I wonder about:

1. Intended use cases for this tool.
2. What are the expected limitations, both now (because of current implementation status) and in the future (theoretical limitations based on design)?

Thanks!

Kristof


Repository:
  rL LLVM

https://reviews.llvm.org/D52341