[PATCH] D52330: SafeStack: Fix flaky test (PR39001)

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 17:20:19 PDT 2018


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: test/safestack/pthread-cleanup.c:38
 
-  if (pthread_create(&t2, NULL, start, NULL))
-    abort();
-  // Second thread destructor cleans up the first thread's stack.
-  if (pthread_join(t2, NULL))
-    abort();
-
-  // should segfault here
-  memset(t1_buffer, 0, kBufferSize);
+  for (int i = 0; i < 3; i++) {
+    if (pthread_create(&t2, NULL, start, NULL))
----------------
Why just 3?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D52330





More information about the llvm-commits mailing list