[PATCH] D51751: Merge clang's isRepeatedBytePattern with LLVM's isBytewiseValue

[JF Bastien via Phabricator via llvm-commits]

jfb added inline comments.


================
Comment at: test/Transforms/MemCpyOpt/memcpy-to-memset.ll:54
+
+ at i1x16 = internal constant <16 x i1> <i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0, i1 0>, align 4
+define void @test_i1x16() nounwind {
----------------
efriedma wrote:
> You're not really testing any interesting codepaths with a constant zero?  We just hit the "isNullValue()" early exit.
It's the only interesting codepath for `i1` though. Unless you're saying that we should add handling for `i1` in `isBytewiseValue`?


Repository:
  rL LLVM

https://reviews.llvm.org/D51751