[PATCH] D50404: [lld-link] Generalize handling of /debug and /debug:{none, full, fastlink, ghash, symtab}

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 15:04:36 PDT 2018


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: COFF/Driver.cpp:950
+      (Debug == DebugKind::Full || Debug == DebugKind::GHash);
   if (ShouldCreatePDB) {
     if (auto *Arg = Args.getLastArg(OPT_pdb))
----------------
If ShouldCreatePDB is used only once, remove the variable and directly write the boolean expression in this `if`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50404





More information about the llvm-commits mailing list