[PATCH] D52319: [GlobalDCE] AvailableExternal linkage is checked in isDiscardableIfUnused [NFC].

[Xin Tong via Phabricator via llvm-commits]

trentxintong updated this revision to Diff 166354.
trentxintong added a comment.

Address @tejohnson comment by adding NFCs to commit msg and summary.


Repository:
  rL LLVM

https://reviews.llvm.org/D52319

Files:
  lib/Transforms/IPO/GlobalDCE.cpp


Index: lib/Transforms/IPO/GlobalDCE.cpp
===================================================================
--- lib/Transforms/IPO/GlobalDCE.cpp
+++ lib/Transforms/IPO/GlobalDCE.cpp
@@ -165,7 +165,7 @@
     // Functions with external linkage are needed if they have a body.
     // Externally visible & appending globals are needed, if they have an
     // initializer.
-    if (!GO.isDeclaration() && !GO.hasAvailableExternallyLinkage())
+    if (!GO.isDeclaration())
       if (!GO.isDiscardableIfUnused())
         MarkLive(GO);
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52319.166354.patch
Type: text/x-patch
Size: 534 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180920/ffea5267/attachment.bin>