[llvm] r342670 - Fix warnings.

Evgenii Stepanov via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 12:51:19 PDT 2018


There are more warnings.
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/15769/steps/bootstrap%20clang/logs/stdio

/b/sanitizer-x86_64-linux/build/llvm/lib/DebugInfo/PDB/PDBExtras.cpp:68:3:
error: default label in switch which covers all enumeration values
[-Werror,-Wcovered-switch-default]
  default:



On Thu, Sep 20, 2018 at 10:48 AM, Zachary Turner via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: zturner
> Date: Thu Sep 20 10:48:44 2018
> New Revision: 342670
>
> URL: http://llvm.org/viewvc/llvm-project?rev=342670&view=rev
> Log:
> Fix warnings.
>
> Modified:
>     llvm/trunk/include/llvm/DebugInfo/PDB/Native/TpiHashing.h
>     llvm/trunk/lib/DebugInfo/PDB/Native/TpiStream.cpp
>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/Native/TpiHashing.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/
> llvm/DebugInfo/PDB/Native/TpiHashing.h?rev=342670&r1=
> 342669&r2=342670&view=diff
> ============================================================
> ==================
> --- llvm/trunk/include/llvm/DebugInfo/PDB/Native/TpiHashing.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/Native/TpiHashing.h Thu Sep 20
> 10:48:44 2018
> @@ -21,19 +21,19 @@ Expected<uint32_t> hashTypeRecord(const
>  struct TagRecordHash {
>    explicit TagRecordHash(codeview::ClassRecord CR, uint32_t Full,
>                           uint32_t Forward)
> -      : Class(std::move(CR)), FullRecordHash(Full),
> ForwardDeclHash(Forward) {
> +      : FullRecordHash(Full), ForwardDeclHash(Forward),
> Class(std::move(CR)) {
>      State = 0;
>    }
>
>    explicit TagRecordHash(codeview::EnumRecord ER, uint32_t Full,
>                           uint32_t Forward)
> -      : Enum(std::move(ER)), FullRecordHash(Full),
> ForwardDeclHash(Forward) {
> +      : FullRecordHash(Full), ForwardDeclHash(Forward),
> Enum(std::move(ER)) {
>      State = 1;
>    }
>
>    explicit TagRecordHash(codeview::UnionRecord UR, uint32_t Full,
>                           uint32_t Forward)
> -      : Union(std::move(UR)), FullRecordHash(Full),
> ForwardDeclHash(Forward) {
> +      : FullRecordHash(Full), ForwardDeclHash(Forward),
> Union(std::move(UR)) {
>      State = 2;
>    }
>
>
> Modified: llvm/trunk/lib/DebugInfo/PDB/Native/TpiStream.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/
> DebugInfo/PDB/Native/TpiStream.cpp?rev=342670&r1=
> 342669&r2=342670&view=diff
> ============================================================
> ==================
> --- llvm/trunk/lib/DebugInfo/PDB/Native/TpiStream.cpp (original)
> +++ llvm/trunk/lib/DebugInfo/PDB/Native/TpiStream.cpp Thu Sep 20 10:48:44
> 2018
> @@ -200,7 +200,6 @@ TpiStream::findFullDeclForForwardRef(Typ
>    if (!ForwardTRH)
>      return ForwardTRH.takeError();
>
> -  TagRecordHash Copy = std::move(*ForwardTRH);
>    uint32_t BucketIdx = ForwardTRH->FullRecordHash %
> Header->NumHashBuckets;
>
>    for (TypeIndex TI : HashMap[BucketIdx]) {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180920/749636ca/attachment.html>


More information about the llvm-commits mailing list