[PATCH] D52312: [DenseMapInfo] Add implementation for SmallVector of pointers.

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 09:50:19 PDT 2018


dexonsmith added a comment.

I'm concerned about propagating this pattern.  `DenseSet`, like `DenseMap`, is tuned for small keys and values.  `SmallVector<void*,4>` is not exactly small, at 48B.  And this patch makes it easy to throw much larger `SmallVector`s into these containers.

I wonder, could these be replaced by `TinyPtrVector`?  They're only 8B.


https://reviews.llvm.org/D52312





More information about the llvm-commits mailing list