[PATCH] D38513: [LLD] [COFF] Add support for GNU binutils import libraries

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/Writer.cpp:378
+    std::map<std::pair<StringRef, uint32_t>, std::vector<Chunk *>> &Map) {
+  const uint32_t RDATA = IMAGE_SCN_CNT_INITIALIZED_DATA | IMAGE_SCN_MEM_READ;
+
----------------
zturner wrote:
> ruiu wrote:
> > nit: we omit `const` if it is obviously a const.
> Do we?  It doesn't hurt anything and prevents the user from modifying the value later.  I don't see a good reason to omit it.
At least in many places in lld, we don't to keep it terse.


https://reviews.llvm.org/D38513