[PATCH] D52285: [SelectionDAG] replace duplicated peekThroughBitcast helper functions; NFCI

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 06:11:24 PDT 2018


spatel added a reviewer: lebedev.ri.
spatel added a comment.

In https://reviews.llvm.org/D52285#1240311, @RKSimon wrote:

> Would we be better off keeping the separate peekThroughOneUseBitcasts helper for clarity? Still putting them both in SelectionDAG


Either way is ok with me. I took this option since it's what we do in IR, but spelling it out in the name does enforce better readability. Anyone else have a preference?


https://reviews.llvm.org/D52285





More information about the llvm-commits mailing list