[PATCH] D50857: llvm: Add support MIPS r6 Debian triples

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 20 03:21:27 PDT 2018


atanasyan added a comment.

Looks good. Thanks. There are a couple notes only:

- Let's extend existing triple unit tests and check that `Triple::getSubArch()` returns `Triple::NoSubArch` for non-R6 architectures.
- I think it's redundant to add https://reviews.llvm.org/source/compiler-rt/ target triple to so many "invalid.s" test cases. We check parsing of a target triple by unit tests. It's enough to take a few MIPS MC or CodeGen tests which use combination of non-R6 target triple and `-mcpu=mips32r6` argument, remove `-mcpu` and replace target triple to https://reviews.llvm.org/source/compiler-rt/ variant.


Repository:
  rL LLVM

https://reviews.llvm.org/D50857





More information about the llvm-commits mailing list